Skip to content

ref(releases): Move release models into releases module #95926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

ref(releases): Move release models into releases module #95926

wants to merge 3 commits into from
+2,349 −2,288

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Jul 18, 2025 •
edited
Loading

Part one of moving release code into a releases module. See the plan here.

For now we move all the models into the releases module and re-export those models through their pre-existing file locations. This keeps the change minimally disruptive and allows us to iteratively change the structure of the releases code.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 18, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
26855 1 26854 205
View the top 1 failed test(s) by shortest run time 
tests.sentry.models.releases.test_release_project.ReleaseProjectManagerTestCase::test_post_save_signal_runs_if_dynamic_sampling_is_enabled_and_latest_release_rule_exists
Stack Traces | 15.6s run time 
#x1B[1m#x1B[.../models/releases/test_release_project.py#x1B[0m:65: in test_post_save_signal_runs_if_dynamic_sampling_is_enabled_and_latest_release_rule_exists
    assert mock_task.mock_calls == [
#x1B[1m#x1B[31mE   AssertionError: assert [] == [call(project...t.post_save')]#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Right contains one more item: call(project_id=4556439601676290, trigger='releaseproject.post_save')#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Full diff:#x1B[0m
#x1B[1m#x1B[31mE     + []#x1B[0m
#x1B[1m#x1B[31mE     - [#x1B[0m
#x1B[1m#x1B[31mE     -     call(project_id=4556439601676290, trigger='releaseproject.post_save'),#x1B[0m
#x1B[1m#x1B[31mE     - ]#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@cmanallen cmanallen mentioned this pull request Jul 18, 2025
Draft
@getsantry
Copy link
Contributor

getsantry bot commented Aug 9, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Aug 9, 2025
@getsantry
Copy link
Contributor

getsantry bot commented Sep 1, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cmanallen